Show Wallet Path on Creation #179
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the wallet creation flow by returning and displaying the wallet file path to users. The change improves user experience by providing immediate feedback about where their wallet data is stored.
- Modified
store_wallet_datato return the wallet file path - Updated
create_encrypted_walletto propagate the file path through its return value - Added user-facing output in
cli_create_walletto display the wallet file location
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/wallet/wallet_storage.rs | Changed store_wallet_data return type from Result<(), BridgeCliError> to Result<PathBuf, BridgeCliError> to return wallet file path |
| src/wallet/mod.rs | Updated create_encrypted_wallet signature to include PathBuf in return tuple and capture the returned wallet file path |
| src/cli.rs | Destructured new return value from create_encrypted_wallet and added user output to display wallet file path |
Comments suppressed due to low confidence (3)
src/wallet/mod.rs:184
- The
store_wallet_datafunction now returns aPathBuf, but this return value is being discarded. Consider capturing and displaying the wallet file path to maintain consistency with the wallet creation flow, similar to how it's displayed incli_create_wallet.
wallet_storage::store_wallet_data(
&address,
network,
&encrypted_mnemonic,
&encrypted_private_key,
true,
Some("mnemonic_import"),
label,
)
.map_err(|e| {
tracing::error!("Error storing wallet data: {}", e);
BridgeCliError::WalletStorageFailed
})?;
src/wallet/mod.rs:270
- The
store_wallet_datafunction now returns aPathBuf, but this return value is being discarded. Consider capturing and displaying the wallet file path to maintain consistency with the wallet creation flow, similar to how it's displayed incli_create_wallet.
wallet_storage::store_wallet_data(
&wallet_address,
network,
&encrypted_mnemonic_data,
&encrypted_private_key_data,
true,
Some("file_import"),
label,
)?;
src/wallet/mod.rs:339
- The
store_wallet_datafunction now returns aPathBuf, but this return value is being discarded. Consider capturing and displaying the wallet file path to maintain consistency with the wallet creation flow, similar to how it's displayed incli_create_wallet.
wallet_storage::store_wallet_data(
&address,
network,
&encrypted_mnemonic,
&encrypted_private_key,
true,
Some("private_key_import"),
label,
)
.map_err(|e| BridgeCliError::Eyre(eyre::eyre!("Failed to store wallet: {}", e)))?;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.